Issue 5 - Remove dependency on five.grok #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def available(self): | ||
| """Return True if an image has been defined.""" | ||
| return self.context.image is not None | ||
| return getattr(self.context, 'image', None) is not None |
There was a problem hiding this comment.
one time the context was plone portal object and this raises exception for me
There was a problem hiding this comment.
this makes no sense; are you registering the viewlet against the right context? you must use ILiveblog.
rodfersou
force-pushed
the
issue_5
branch
3 times, most recently
from
5bb16c4
to
bcd954e
Compare
hvelarde
changed the title
hvelarde
added a commit
that referenced
this pull request
May 4, 2016
The view was not returning any content after removal of five.grok (refs. #22).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5