Issue 23 - Remove liveblog workflow #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| modified = datetime.fromtimestamp(timestamp) | ||
| timedelta = datetime.now() - modified | ||
| # Last modification is less than 2 days ago | ||
| return timedelta.days < 2 |
There was a problem hiding this comment.
you better compare against a timedelta object, something like:
from datetime import timedelta
return timedelta(days=1) < datetime.now() - modified
|
you forgot to update the documentation |
|
I didn't forget, the PR is not ready |
| @@ -1,9 +1,9 @@ | |||
| <?xml version="1.0"?> | |||
| <object name="portal_workflow" meta_type="Plone Workflow Tool"> | |||
| <object name="liveblog_workflow" meta_type="Workflow"/> | |||
| <object name="liveblog_workflow" meta_type="Workflow" purge="True" /> | |||
There was a problem hiding this comment.
this can be done programmatically to avid having to register a new profile
rodfersou
force-pushed
the
issue_23
branch
4 times, most recently
from
b623cad
to
6bcc3cd
Compare
| # simulate (partially) state on previous version | ||
| wtool = api.portal.get_tool('portal_workflow') | ||
| wtool.setChainForPortalTypes(('Liveblog',), ('liveblog_workflow',)) | ||
| assert wtool.getChainForPortalType('Liveblog') == ('liveblog_workflow',) |
There was a problem hiding this comment.
why not use self.assertEqual here?
There was a problem hiding this comment.
because that is not a test, but a precondition for a test; the result is the same, is just semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23