Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to enable metadata functionality sitewide #19

Merged
merged 12 commits into from Jun 14, 2017

Conversation

ichim-david
Copy link
Member

This pull request has two major changes:

  1. A performance improvement where I save the old content types values within Annotation
    in order to avoid that catalog search for all content types tagged just so that you know
    what is new and what is old when you change the content type listing
  2. I've added a new Boolean field enabled_sitewide which if enabled will activate the content
    metatags globally bypassing the need to enabled and disable manual per content type and object
    If you disable the option than the package continues to work as it worked before the addition of
    this feature.

The reason for this feature is because when you have a portal with a large number of documents (100,000+) attempting to do a catalog search to reindex all is something that takes a long time.
Another reason for adding this feature is because in Plone 5 you have a sitewide enable or disable
of these "social media" tags without any interface checks and reindexes which makes it easier to
use on sites with many objects.

Let me know if you need anything changes and I will try to reply ASAP

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 57.465% when pulling 776eaa4 on eea:master into a4785f4 on collective:master.

@erral
Copy link
Member

erral commented Jun 12, 2017

I see I merged the last pull-request here...

I basically agree with your changes, specially the one to enable sitewide the metatags...

@erral erral self-assigned this Jun 12, 2017
@erral
Copy link
Member

erral commented Jun 12, 2017

I can merge it if you want.

Then we will need to ping people from redturtle to make a release. on pypi the product is owned by @amleczko and @massimoazzolini can you give someone else rights on pypi?

@ichim-david
Copy link
Member Author

@erral that would be great both on pypi front and the merging
but before you do that I will add a history entry for this pull request
work as I intended to do so after I got any feedback from having this pull request
open

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 57.465% when pulling 47a8a78 on eea:master into a4785f4 on collective:master.

@erral
Copy link
Member

erral commented Jun 14, 2017

@ichim-david is this ready?

@ichim-david
Copy link
Member Author

@erral yes it is I have added the history entry that i've mentioned yesterday

@erral erral merged commit aeb5596 into collective:master Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants