Register views and resources against a package-specific browser layer…

…. This fixes issue #7.
collective · May 16, 2012 · 0f83c67 · 0f83c67
1 parent e042861
commit 0f83c67
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -8,6 +8,12 @@ Features:
 - Added option to select standard, double or triple spacing, all of
   which are given as a percentage of the page width.
 
+Bugfixes:
+
+- Views and resources are now registered against a package-specific
+  browser layer. This ensures that the user interface is not available
+  unless the product is installed (issue #6).
+
 1.1 (2012-05-15)
 ----------------
 

diff --git a/src/collective/panels/configure.zcml b/src/collective/panels/configure.zcml
@@ -46,6 +46,7 @@
       view="plone.app.layout.globals.interfaces.IViewView"
       template="link.pt"
       permission="plone.app.portlets.ManagePortlets"
+      layer=".interfaces.ILayer"
       />
 
   <browser:viewlet
@@ -64,6 +65,7 @@
       manager="plone.app.layout.viewlets.interfaces.IAboveContentBody"
       class=".browser.DisplayViewlet"
       permission="zope2.View"
+      layer=".interfaces.ILayer"
       />
 
   <browser:viewlet
@@ -72,6 +74,7 @@
       manager="plone.app.layout.viewlets.interfaces.IBelowContentBody"
       class=".browser.DisplayViewlet"
       permission="zope2.View"
+      layer=".interfaces.ILayer"
       />
 
   <browser:viewlet
@@ -80,6 +83,7 @@
       manager="plone.app.layout.viewlets.interfaces.IPortalFooter"
       class=".browser.DisplayViewlet"
       permission="zope2.View"
+      layer=".interfaces.ILayer"
       />
 
   <browser:viewlet
@@ -88,14 +92,16 @@
       manager="plone.app.layout.viewlets.interfaces.IPortalTop"
       class=".browser.DisplayViewlet"
       permission="zope2.View"
+      layer=".interfaces.ILayer"
       />
 
   <!-- Views -->
 
   <browser:pages
       for=".content.Panel"
       class=".browser.ManageView"
-      permission="plone.app.portlets.ManagePortlets">
+      permission="plone.app.portlets.ManagePortlets"
+      layer=".interfaces.ILayer">
 
     <browser:page
         name="-"
@@ -124,6 +130,7 @@
         for="collective.panels.content.Panel"
         name="manage-portlets-macros"
         template="templates/edit-manager-macros.pt"
+        layer="collective.panels.interfaces.ILayer"
         permission="plone.app.portlets.ManageOwnPortlets"
         />
   </configure>
@@ -132,13 +139,15 @@
       name="display"
       for=".content.Panel"
       class=".browser.DisplayView"
+      layer=".interfaces.ILayer"
       permission="zope2.View"
       />
 
   <browser:page
       name="manage-panels"
       for="*"
       class=".browser.ManagePanelsView"
+      layer=".interfaces.ILayer"
       permission="plone.app.portlets.ManagePortlets"
       />
 
@@ -179,6 +188,7 @@
   <browser:resource
       name="panels.css"
       file="styles.css"
+      layer=".interfaces.ILayer"
       />
 
 </configure>
diff --git a/src/collective/panels/interfaces.py b/src/collective/panels/interfaces.py
@@ -11,6 +11,10 @@
 from .i18n import MessageFactory as _
 
 
+class ILayer(Interface):
+    """Package-specific browser layer."""
+
+
 class ILayout(Interface):
     """Marker for a layout dictionary."""
 

diff --git a/src/collective/panels/profile/browserlayer.xml b/src/collective/panels/profile/browserlayer.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0"?>
+<layers>
+  <layer name="collective.panels"
+         interface="collective.panels.interfaces.ILayer"
+         />
+</layers>