Add support for Plone 5/6 and Python 3 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
reviewed
Mar 10, 2022
| href=""> | ||
| <img tal:replace="structure image/tag" /> | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
Seems weird that image is removed here and in the renderer, but still in the item_display vocabulary. If intentional, should that be mentioned in the history?
| @@ -82,7 +71,7 @@ class IContentPortlet(IPortletDataProvider): | |||
| value_type=schema.Choice( | |||
| vocabulary='collective.portlet.content.item_display_vocabulary', | |||
| ), | |||
| default=[u'date', u'image', u'description', u'body'], | |||
| default=[u'date', u'description'], | |||
There was a problem hiding this comment.
Isn't the point of this portlet to display the body?
| more_text = u'' | ||
| omit_border = False | ||
| custom_header = u"" | ||
| omit_header = False | ||
|
|
||
| def __init__(self, portlet_title=u'', content=None, title_display=u'link', | ||
| item_display=[u'date', u'image', u'description', u'body'], more_text=u'', | ||
| item_display=[u'date', u'description'], more_text=u'', |
There was a problem hiding this comment.
mutable default is a code smell
| @@ -149,7 +137,7 @@ def title(self): | |||
| "manage portlets" screen. | |||
| """ | |||
| msg = __(u"Content portlet") | |||
| return self.portlet_title or msg | |||
| return getattr(uuidToCatalogBrain(self.content), 'Title', None) or msg | |||
There was a problem hiding this comment.
Should still use portlet_title if set, right?
| @@ -226,17 +198,17 @@ def body(self): | |||
|
|
|||
| # Currently nothing stops you from trying to get text from an Image | |||
| if hasattr(self.content, 'getText'): | |||
| text = self.content.getText() | |||
| text = self.content.getText | |||
There was a problem hiding this comment.
The brain probably does not have getText; for this you probably need the real content item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.