fix(permissions): add portlet oembed was only available to admin

collective · Sep 24, 2013 · 0abb195 · 0abb195
1 parent 3f5b99d
commit 0abb195
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/collective/portlet/oembed/__init__.py b/collective/portlet/oembed/__init__.py
@@ -11,5 +11,10 @@
 ploneMessageFactory = MessageFactory('plone')
 
 from Products.CMFCore.permissions import setDefaultRoles
-setDefaultRoles('collective.portlet.embed: Add oembed portlet',
+from AccessControl.SecurityInfo import ModuleSecurityInfo
+
+security = ModuleSecurityInfo('collective.portlet.oembed')
+security.declarePublic('')
+AddOembedPortlet = 'collective.portlet.embed: Add oembed portlet'
+setDefaultRoles(AddOembedPortlet,
                 ('Manager', 'Site Administrator', 'Owner',))
diff --git a/collective/portlet/oembed/profiles/default/metadata.xml b/collective/portlet/oembed/profiles/default/metadata.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <metadata>
-  <version>1003</version>
+  <version>1004</version>
   <dependencies>
     <dependency>profile-collective.oembed:default</dependency>
   </dependencies>

diff --git a/collective/portlet/oembed/profiles/default/rolemap.xml b/collective/portlet/oembed/profiles/default/rolemap.xml
@@ -0,0 +1,10 @@
+<?xml version="1.0"?>
+<rolemap>
+ <permissions>
+  <permission name="collective.portlet.oembed: Add oembed portlet" acquire="True">
+   <role name="Manager"/>
+   <role name="Site Administrator"/>
+   <role name="Owner"/>
+  </permission>
+ </permissions>
+</rolemap>
diff --git a/collective/portlet/oembed/upgrades.zcml b/collective/portlet/oembed/upgrades.zcml
@@ -4,7 +4,7 @@
 
     <upgradeStep
         source="*"
-        destination="1003"
+        destination="1004"
         title="Upgrade"
         description=""
         profile="collective.portlet.oembed:default"