set content type to application/json

[reinhardt]

text/json is not supported by old IEs but text/html fails in every browser with plone.protect 3.0.11

[davisagli]

I think you want application/json

[reinhardt]

text/json did fix it for me but application/json makes more sense now you mention it. Cheers!

[pysailor]

@davisagli @frisi This PR fixes the false "Failed" error message for me in yet another Plone project (4.3.2).
Can you please merge this and make a new release? I would be happy to do that too, my Pypi username is "thomasw".
Cheers

[davisagli]

@pysailor not sure why you addressed @frisi and me; the owners on PyPI are: thet, maethu, vincentfretin, encolpe, ingeniweb, tdesvenain, macadames

[maethu]

@reinhardt Which IE's are no longer supported?

[reinhardt]

In our tests IE9 and earlier still had problems. Bear in mind though that with the recent hotfix those versions have problems with the old content-type setting as well.

[pysailor]

@davisagli Sorry, you're right. I had just seen that you had replied on this PR / the ticket referencing it and addressed you by default. I hadn't really checked if you're also maintainers.

[frisi]

IE9 wants do download the @@quick_upload_file response (see screenshot), but the file upload works

@thet: should we add the hotfix to the test-buildout-configs (at least for test-plone-4.3.x.cfg)?

[buildout]
extends =
    test-plone-4.3.x.cfg

eggs += 
    plone4.csrffixes

[versions]
plone.protect = 3.0.14
plone.keyring = 3.0.1
plone.locking = 2.0.8
plone4.csrffixes = 1.0.6

@thet could you add me as a maintainer? i'd add the hotfix to the tests (if you think that makes sense), squash the commits and do the release

[frisi]

@reinhardt: could you squash your commits please?

@thet , @tdesvenain could you please comment on my proposal to add the csrf-hotfix to the tests.
also, a new release should be done as this affects a lot of people. could you please do the release, or grant me permission? thanks!

[mauritsvanrees]

Fix looks good to me.

Adding plone4.csrffixes to the test buildout is fine with me. But just to be sure: not to setup.py please in any way. Getting plone4.csrffixes added in another buildout just because you add collective.quickupload would be a bad thing.

Oh, if you are going to squash commits, please rebase on master too as that has already done the unittest2 dependency better than on this pull request branch.

[reinhardt]

Thanks for the comments! I've squashed and rebased.

[vincentfretin]

@thet and me have pypi owner role. If somebody want to have Owner role to make a new release please give me your pypi login.

[thet]

@pysailor @frisi sorry for not coming back to that earlier. i gave you both pypi access. happy releasing!

[frisi]

thanks @reinhardt @mauritsvanrees @thet and @vincentfretin - release is done

[reinhardt]

Brilliant, cheers!