Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use blob_timestamps #65

Open
mauritsvanrees opened this issue Sep 9, 2022 · 2 comments
Open

Always use blob_timestamps #65

mauritsvanrees opened this issue Sep 9, 2022 · 2 comments
Assignees
@mauritsvanrees

Comments

@mauritsvanrees
Copy link
Member

I always have this on. In release 4.2.0 we changed the default from False to True. So no more blobstorage.0, blobstorage.1, etcetera.
@mauritsvanrees mauritsvanrees self-assigned this Sep 9, 2022
@mauritsvanrees
Copy link
Member Author

This also means we can remove the keep_blob_days option, because this is handled automatically with blob timestamps.

mauritsvanrees added a commit that referenced this issue Feb 5, 2023
@mauritsvanrees
Issue 65: start removing blob timestamps option.
e62ede1 
It should be always true.
But it is tricky, needing a lot of changes.
And we need to keep some of the old code still, otherwise we cannot restore previously created blob backups.
See #65
mauritsvanrees added a commit that referenced this issue Feb 7, 2023
@mauritsvanrees
Deprecate setting blob_timestamps to false.
619fbd2 
See #65
@mauritsvanrees mauritsvanrees mentioned this issue Feb 7, 2023
Merged
@mauritsvanrees
Copy link
Member Author

I have deprecated this in version 5.0.0a3, and display this message when someone explicitly has blob_timestamps=false:

You have disabled blob_timestamps. Support for this may be dropped in version 6, making it impossible to restore backups without timestamps. See #65

I am not 100 percent sure I will actually drop it. But repozo only makes backups with timestamps in the name, so it makes sense to use the same scheme in the blobstorage backups.

If I drop it, you can still restore older backups with an older version of the backup script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mauritsvanrees