Skip to content

Commit

Permalink
py3 compat
Browse files Browse the repository at this point in the history
  • Loading branch information
gotcha committed Mar 31, 2020
1 parent 0483534 commit 741f963
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
3 changes: 3 additions & 0 deletions buildout.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,15 @@ collective.recipe.plonesite = 1.11.0

[versions:os.environ.get('PLONE_VERSION', '4.3').startswith('4.')]
collective.upgrade = 1.5
zodbupdate = 0.5

[versions:os.environ.get('PLONE_VERSION', '4.3') == '5.1']
collective.upgrade = 1.5
zodbupdate = 0.5

[versions:os.environ.get('PLONE_VERSION', '4.3') == '5.2']
collective.upgrade = 1.6
zodbupdate = 1.4

[instance]
eggs += collective.upgrade
Expand Down
6 changes: 3 additions & 3 deletions collective/searchandreplace/pytests/zope_instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,17 @@ def __init__(
output = subprocess.check_output(
["bin/buildout", "query", "buildout:develop"]
)
assert str(package_path) in output
assert str(package_path).encode('utf8') in output

output = subprocess.check_output(
["bin/buildout", "query", "instance:recipe"]
)
assert 'plone.recipe.zope2instance' in output
assert b'plone.recipe.zope2instance' in output

output = subprocess.check_output(
["bin/buildout", "query", "plonesite:recipe"]
)
assert 'collective.recipe.plonesite' in output
assert b'collective.recipe.plonesite' in output

def run_buildouts(self, from_version):
retcode = subprocess.call(
Expand Down
9 changes: 7 additions & 2 deletions collective/searchandreplace/tests/test_replacewhere.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# -*- coding: utf-8 -*-
from collective.searchandreplace.interfaces import ISearchReplaceUtility
from collective.searchandreplace.interfaces import ISearchReplaceSettings
from collective.searchandreplace.testing import edit_content
Expand All @@ -11,6 +12,7 @@
from plone.app.testing import TEST_USER_NAME
from Products.CMFCore.utils import getToolByName
from zope.component import getUtility
import six

import unittest

Expand Down Expand Up @@ -503,11 +505,14 @@ def testReplaceSubjectUnicode(self):
)
results = self.srutil.findObjects(**parameters)
self.assertEqual(len(results), 1)
r_parameters = dict(replaceWith="Remplac\xc3\xa9".decode('utf8'),)
r_parameters = dict(replaceWith=u"Remplacé",)
r_parameters.update(parameters)
results = self.srutil.replaceAllMatches(**r_parameters)
self.assertEqual(results, 1)
self.assertEqual(doc1.Subject(), ("Remplac\xc3\xa9", "Replaced"))
if six.PY3:
self.assertEqual(doc1.Subject(), (u"Remplacé", "Replaced"))
if six.PY2:
self.assertEqual(doc1.Subject(), (u"Remplacé".encode('utf8'), "Replaced"))

class TestModified(unittest.TestCase):
"""Test update_modified setting"""
Expand Down

0 comments on commit 741f963

Please sign in to comment.