New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Profile Handling #40
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 174
💛 - Coveralls |
Pull Request Test Coverage Report for Build 327
💛 - Coveralls |
16e4a11
to
a12f9cd
Compare
@sarn0ld is this something we would like to have in the next release..? |
# Conflicts: # src/collective/sidebar/utils.py
@Netroxen I would like to have it in the next release and I can confirm that it works in one of our internal projects (actionbike, except for facebookusers...) . But these are not everyday-changes, they seriously need tests, before we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as far as I can see. But it seriously needs tests!
This implements the custom member functionality found in the portal_membership tool of the ZMI.
The sidebar now implements a
sidebar.user_avatar('schema_field_name')
to allow fields in a custom Content-Type to be used for the sidebar avatar image.