Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Profile Handling #40

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Netroxen
Copy link
Collaborator

@Netroxen Netroxen commented Feb 1, 2019

This implements the custom member functionality found in the portal_membership tool of the ZMI.

The sidebar now implements a sidebar.user_avatar('schema_field_name') to allow fields in a custom Content-Type to be used for the sidebar avatar image.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 174

  • 21 of 51 (41.18%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.08%) to 57.817%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/collective/sidebar/directives.py 8 15 53.33%
src/collective/sidebar/utils.py 3 11 27.27%
src/collective/sidebar/browser/sidebar.py 8 23 34.78%
Totals Coverage Status
Change from base Build 169: -3.08%
Covered Lines: 196
Relevant Lines: 339

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 1, 2019

Pull Request Test Coverage Report for Build 327

  • 21 of 51 (41.18%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.2%) to 88.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/collective/sidebar/directives.py 8 15 53.33%
src/collective/sidebar/utils.py 3 11 27.27%
src/collective/sidebar/browser/sidebar.py 8 23 34.78%
Totals Coverage Status
Change from base Build 324: -7.2%
Covered Lines: 342
Relevant Lines: 386

💛 - Coveralls

@Netroxen
Copy link
Collaborator Author

Netroxen commented Aug 5, 2019

@sarn0ld is this something we would like to have in the next release..?

@sarn0ld
Copy link
Collaborator

sarn0ld commented Oct 8, 2019

@Netroxen I would like to have it in the next release and I can confirm that it works in one of our internal projects (actionbike, except for facebookusers...) . But these are not everyday-changes, they seriously need tests, before we can merge it.

@sarn0ld sarn0ld self-requested a review October 8, 2019 07:12
Copy link
Collaborator

@sarn0ld sarn0ld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as far as I can see. But it seriously needs tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants