Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#33 select default view #48

Merged
merged 4 commits into from May 9, 2019
Merged

#33 select default view #48

merged 4 commits into from May 9, 2019

Conversation

sarn0ld
Copy link
Collaborator

@sarn0ld sarn0ld commented May 8, 2019 •
edited

Fixes #33
This fixes a small bug, too: After setting a default page it was not possible to set another one.

There was no specification on icons. Hope it's okay like this.
For listing the registred views I created another ticket: #49

@coveralls
Copy link

coveralls commented May 8, 2019 •
edited

Pull Request Test Coverage Report for Build 218

  • 10 of 14 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 62.647%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/collective/sidebar/browser/sidebar.py 10 14 71.43%
Totals Coverage Status
Change from base Build 216: 0.4%
Covered Lines: 213
Relevant Lines: 340
💛 - Coveralls

@sarn0ld sarn0ld changed the title Issue 33 select default view #33 select default view May 8, 2019
@sarn0ld sarn0ld mentioned this pull request May 8, 2019
Open
@sarn0ld sarn0ld merged commit a029a03 into master May 9, 2019
@Netroxen Netroxen deleted the issue_33_select_default_view branch May 20, 2019 14:48
Netroxen pushed a commit that referenced this pull request May 22, 2019
@sarn0ld
#33 select default view (#48)
11b8bad 
* Added a link to select_default_view. This fixes #33 .

* Bugfix to still be able to choose default view/page after it was set already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santonelli santonelli santonelli approved these changes

@Netroxen Netroxen Awaiting requested review from Netroxen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select Default View in Sidebar
3 participants
@sarn0ld @coveralls @santonelli