solr.cfg: configure JMX host and port separately. #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config was hardcoding the JMX (Java Management Extensions) host and port. Now it is clearer that you can configure them.
Mostly, I found it strange that there was a
solr-port
setting and we were completely ignoring that in thejava_opts
and instead used hardcoded port 8984. To me this gave the impression that this port 8984 was only used at build time to maybe set a default, and thatsolr-instance fg
would just use the port from the settings and port 8984 would never be used.Initially I changed that to use the same settings, with
${:host}
and${:port}
.That seems to work fine, and we could also use that to keep things simple.
But probably it is better to keep the ports separate.
I did not know JMX, but you can start
jconsole
and connect to your Solr instance and see some statistics. See https://cwiki.apache.org/confluence/display/solr/Using+JMX+with+Solr