Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solr.cfg: configure JMX host and port separately. #159

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

mauritsvanrees
Copy link
Member

The config was hardcoding the JMX (Java Management Extensions) host and port. Now it is clearer that you can configure them.

Mostly, I found it strange that there was a solr-port setting and we were completely ignoring that in the java_opts and instead used hardcoded port 8984. To me this gave the impression that this port 8984 was only used at build time to maybe set a default, and that solr-instance fg would just use the port from the settings and port 8984 would never be used.

Initially I changed that to use the same settings, with ${:host} and ${:port}.
That seems to work fine, and we could also use that to keep things simple.
But probably it is better to keep the ports separate.

I did not know JMX, but you can start jconsole and connect to your Solr instance and see some statistics. See https://cwiki.apache.org/confluence/display/solr/Using+JMX+with+Solr

@gforcada
Copy link
Contributor

When running multiple jenkins jobs one can lead to a situation where both jobs try to bind to that port, so getting a random port from jenkins port allocator for both connections will be really helpful.

@tisto
Copy link
Member

tisto commented Nov 18, 2016

@mauritsvanrees pls fix merge conflicts.

@mauritsvanrees
Copy link
Member Author

I have rebased.

@mauritsvanrees
Copy link
Member Author

BTW, I think this is my last fix for collective.solr (and one pull request pending for the solrinstance recipe) for the short future, so releases are welcome. :-)

@gforcada gforcada merged commit 1dd3456 into master Nov 18, 2016
@gforcada gforcada deleted the separate-jmx-port-setting branch November 18, 2016 14:01
@tisto
Copy link
Member

tisto commented Nov 18, 2016

@mauritsvanrees will do a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants