Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the skins folder and script #2

Open
keul opened this issue Apr 8, 2014 · 2 comments
Open

Remove the skins folder and script #2

keul opened this issue Apr 8, 2014 · 2 comments

Comments

@keul
Copy link
Member

keul commented Apr 8, 2014

Now that issue https://dev.plone.org/ticket/11317 has been closed, we don't need a custom folder_position script.

See also plone/Products.CMFPlone@a734a1c

@mauritsvanrees
Copy link
Member

We don't need the custom script if the end user has Plone 4.3. For older Plones it is still needed.

Also, I have just added a branch (renewed from an older branch that I have now removed) where I add some more small changes to the folder_position script. See pull request #3.
I have added those changes in CMFPlone too just now, but they have of course not been released yet:
plone/Products.CMFPlone@ee99d89

So I would say: we still need the skins folder and script.

@keul
Copy link
Member Author

keul commented Jul 3, 2014

Ok, so let's keep this open for a while.
When a new Plone version (4.3.4?) will be released we can probably drop the skin folder and release a new (2.0) version that drop compatibility with older Plone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants