Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix language issues #89

Merged
merged 8 commits into from
Jun 26, 2020
Merged

Fix language issues #89

merged 8 commits into from
Jun 26, 2020

Conversation

petschki
Copy link
Member

fixes #80

@petschki
Copy link
Member Author

@rodfersou this is my work from yesterday ... feel free to test/change it

@rodfersou
Copy link
Member

@petschki great! thanks

@rodfersou rodfersou self-assigned this Jun 25, 2020
@rodfersou rodfersou marked this pull request as ready for review June 25, 2020 11:09
rodfersou
rodfersou approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@rodfersou rodfersou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a test:

  • Create Taxonomy
  • Create Taxonomy data
  • Added the behavior for Page
  • Added a Page categorizing
  • Added a Collection filtering the page created

Everything works like a charm!

@rodfersou
Copy link
Member

@petschki could you please just look my last commit if you agree?

@rodfersou
Copy link
Member

@petschki I would like to merge this when get green if you agree :)

@rodfersou
Copy link
Member

green!

@petschki petschki merged commit ff375e9 into master Jun 26, 2020
@petschki petschki deleted the issue_80 branch June 26, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodfersou rodfersou rodfersou approved these changes

@ericof ericof Awaiting requested review from ericof

Assignees

@rodfersou rodfersou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when add page with taxonomy behavior
2 participants
@petschki @rodfersou