Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lint tools and check code format on CI #92

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Use Lint tools and check code format on CI #92

merged 4 commits into from
Jun 26, 2020

Conversation

rodfersou
Copy link
Member

@rodfersou rodfersou commented Jun 26, 2020 •
edited

closes #85

@rodfersou rodfersou mentioned this pull request Jun 26, 2020
Closed
@rodfersou
Copy link
Member Author

With those tools, we will be free to think about real problems and don't need to think about code format.

After run make build will register a hook that will lint the code before each commit automatically.

@rodfersou rodfersou changed the title Ci add code format Use Lint tools and check code format on CI Jun 26, 2020
petschki
petschki approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodfersou rodfersou merged commit ff7877f into master Jun 26, 2020
@rodfersou rodfersou deleted the ci-add-code-format-2 branch June 26, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petschki petschki petschki approved these changes

@gotcha gotcha Awaiting requested review from gotcha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI don't test code format (we should use Black)
2 participants
@rodfersou @petschki