Skip to content

Commit

Permalink
Merge pull request #28 from collective/issue_24
Browse files Browse the repository at this point in the history
Disable the feature globally at installation time
  • Loading branch information
rodfersou committed Jun 15, 2016
2 parents 0aa31c1 + bc8a043 commit a74cede
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ Changelog
1.0b2 (unreleased)
------------------

- To avoid displaying the '🔊 Listen' button with an incorrect voice,
the feature is now globally disabled by default at installation time.
[hvelarde]

- ResponsiveVoice library is now only loaded when needed.
[hvelarde]

Expand Down
2 changes: 1 addition & 1 deletion src/collective/texttospeech/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ITextToSpeechControlPanel(form.Schema):
globally_enabled = schema.Bool(
title=_(u'Enable Text-to-Speech?'),
description=_(u'If selected, Text-to-Speech feature will be enabled sitewide.'),
default=True,
default=False,
)

enabled_content_types = schema.List(
Expand Down
2 changes: 1 addition & 1 deletion src/collective/texttospeech/tests/test_controlpanel.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def setUp(self):

def test_globally_enabled_record_in_registry(self):
self.assertTrue(hasattr(self.settings, 'globally_enabled'))
self.assertEqual(self.settings.globally_enabled, True)
self.assertEqual(self.settings.globally_enabled, False)

def test_enabled_content_types_record_in_registry(self):
self.assertTrue(hasattr(self.settings, 'enabled_content_types'))
Expand Down

0 comments on commit a74cede

Please sign in to comment.