Use version 1.5 of the ResponsiveVoice API #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
force-pushed
the
update-package
branch
from
52a7937
to
8c36bdc
Compare
hvelarde
requested changes
Apr 16, 2018
| OLD_JS = '//code.responsivevoice.org/1.4/responsivevoice.js' | ||
|
|
||
|
|
||
| def pin_responsivevoice(setup_tool): |
There was a problem hiding this comment.
seems this upgrade step is not supported under Plone 5.1; better ask @thet for advice on how to fix this.
There was a problem hiding this comment.
@thet any advice on how to fix JS registration on Plone 5.1?
There was a problem hiding this comment.
take a look at collective/collective.lazysizes#36 but I think is better to provide different profiles for different Plone versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36