forked from mjpieters/collective.transmogrifier
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 #7
Closed
Closed
PEP8 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a section tells the transmogrifier about the created archive (by calling transmogrifier.add_info('export_content', name, info), e.g. at the end of the __iter__ method), the calling method can return this archive to the user for download. This way, transmogrifier turns into a tool which can be offered to "normal" users for flexible exports, without the need to edit the pipeline configuration first.
Here is all the meat!
Produces a pretty string which represents the _all attribute of a Transmogrifier object. Can return a list instead. Conflicts: src/collective/transmogrifier/utils.py
When ConfigurationRegistry.clear is fired unexpectedly, this can go unnoticed and cause transmogrifications to fail. Thus, this can be customized by setting the CLEANUP variable. To suppress the call by the zope.testing.cleanup facility entirely, this variable must must be changed to OFF in the module code, because this is done on import time. For other uses, the variable can be set after importing. The present SILENT value reflects the so-far behaviour. Conflicts: src/collective/transmogrifier/transmogrifier.py
Merged
Closed via: #10 |
Have to reopen - I withdraw the attempt to rebase on your PR, as it is not only simple PEP8 but also adds new functionality. |
perhaps outdated, reopen if i am wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Called
pep8ify -wn
, and edited the result.Most changes are the removal of trailing whitespace.
Alignment of comments recovered.
Backup files of editors (...) are ignored.