Portlet improvement

collective · Oct 31, 2013 · 77ca50d · 77ca50d
1 parent d89c3e3
commit 77ca50d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/collective/weather/portlets/weather.pt b/src/collective/weather/portlets/weather.pt
@@ -1,13 +1,14 @@
 <dl  class="portlet portletWeather"
      i18n:domain="collective.weather"
-     tal:define="portal context/@@plone_portal_state/portal">
+     tal:define="portal context/@@plone_portal_state/portal;
+                 current_city view/current_city|nothing"
+     tal:condition="current_city">
 
     <dt class="portletHeader">
         <span tal:content="view/data/header">Weather</span>
     </dt>
 
     <dd i18n:domain="collective.weather"
-        tal:define="current_city view/current_city|nothing"
         tal:condition="current_city">
 
         <span tal:define="city_name current_city/name|nothing"

diff --git a/src/collective/weather/portlets/weather.py b/src/collective/weather/portlets/weather.py
@@ -68,11 +68,9 @@ def update(self):
             self.current_city = {'id': location.value, 'name': location.title}
 
         self.weather_info = None
-        try:
+        if not self.current_city is None:
             weather_utility.update_weather_info(self.current_city['id'])
             self.weather_info = weather_utility.get_weather_info(self.current_city)
-        except:
-            pass
 
 
 class AddForm(base.AddForm):