implement selection of location in portlet #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| class IWeatherPortlet(IPortletDataProvider): | ||
| """A weather portlet. | ||
| """ | ||
| '''A weather portlet. |
There was a problem hiding this comment.
according to PEP 257 -- Docstring Conventions:
For consistency, always use """triple double quotes""" around docstrings
so, please do not replace """ with '''.
Conflicts: src/collective/weather/portlets/weather.pt
ghost
assigned 
|
Changes Unknown when pulling 7ee1ee0 on issue_15 into * on master*. |
|
Changes Unknown when pulling d89c3e3 on issue_15 into * on master*. |
| IVocabularyFactory, name='collective.weather.Locations') | ||
| vocab = factory(self.context) | ||
| self.current_city = None | ||
| if self.data.location in vocab: |
There was a problem hiding this comment.
what happens if the location is not in the vocabulary?
There was a problem hiding this comment.
weather_info is not calculated and the portlet is not shown
|
Changes Unknown when pulling 2b5ddae on issue_15 into * on master*. |
|
Changes Unknown when pulling 2b5ddae on issue_15 into * on master*. |
|
Changes Unknown when pulling bff2f06 on issue_15 into * on master*. |
hvelarde
added a commit
that referenced
this pull request
Nov 1, 2013
implement selection of location in portlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15