Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display column description if provided in schema field.description. #76

Merged
merged 1 commit into from Sep 13, 2018
Merged

Display column description if provided in schema field.description. #76

merged 1 commit into from Sep 13, 2018

Conversation

gbastien
Copy link
Member

This is related to issur #75

Thank you for review!

I will also back port this to branch 1.2.x as we need this for a Plone4.3 application.

Gauthier

@keul
Copy link
Member

keul commented Sep 13, 2018

@gbastien sorry I'm not involved in any Plone activity anymore, can't say if this ok! 😄

keul
keul approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@keul keul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK (untested!)

@coveralls
Copy link

coveralls commented Sep 13, 2018 •
edited

Pull Request Test Coverage Report for Build 221

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 76.19%
Files with Coverage Reduction New Missed Lines %
src/collective/z3cform/datagridfield/demo/editform_simple.py 2 69.05%
src/collective/z3cform/datagridfield/datagridfield.py 4 84.85%
Totals Coverage Status
Change from base Build 217: 0.0%
Covered Lines: 528
Relevant Lines: 693
💛 - Coveralls

@hvelarde hvelarde merged commit 2b8e2e5 into master Sep 13, 2018
@hvelarde hvelarde deleted the column_description branch September 13, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensens jensens jensens approved these changes

@keul keul keul approved these changes

@tomgross tomgross Awaiting requested review from tomgross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gbastien @keul @coveralls @jensens @hvelarde