Versions for Plone

[gbastien]

Hi @jensens,

this will avoid time lost to other people using this ;-)

Thank you, feel free to adapt changes if necessary.

Gauthier

[coveralls]

Pull Request Test Coverage Report for Build 226

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 8 unchanged lines in 2 files lost coverage.
• Overall coverage remained the same at 76.19%

---

Files with Coverage Reduction	New Missed Lines	%
src/collective/z3cform/datagridfield/datagridfield.py	2	84.85%
src/collective/z3cform/datagridfield/demo/editform_simple.py	6	69.05%

Totals
Change from base Build 222:	0.0%
Covered Lines:	528
Relevant Lines:	693

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 226

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 8 unchanged lines in 2 files lost coverage.
• Overall coverage remained the same at 76.19%

---

Files with Coverage Reduction	New Missed Lines	%
src/collective/z3cform/datagridfield/datagridfield.py	2	84.85%
src/collective/z3cform/datagridfield/demo/editform_simple.py	6	69.05%

Totals
Change from base Build 222:	0.0%
Covered Lines:	528
Relevant Lines:	693

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 226

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 8 unchanged lines in 2 files lost coverage.
• Overall coverage remained the same at 76.19%

---

Files with Coverage Reduction	New Missed Lines	%
src/collective/z3cform/datagridfield/datagridfield.py	2	84.85%
src/collective/z3cform/datagridfield/demo/editform_simple.py	6	69.05%

Totals
Change from base Build 222:	0.0%
Covered Lines:	528
Relevant Lines:	693

---

💛 - Coveralls

[gbastien]

Hi @jensens @idgserpro

can this be merged so it is clear what version to use depending on Plone4 or Plone5?

Thank you,

Gauthier

[jensens]

thanks!

[idgserpro]

This PR seems incomplete... where exactly did you get this information?

Versions >= 1.3 are for Plone 5+, if you use Plone 4.3, use versions 1.2.x

Right now, in

collective.z3cform.datagridfield/setup.py

Line 21 in 7b9e9bf

'Framework :: Plone :: 4.3',

, it says 4.3 is compatible. So this would need to be changed as well.

[gbastien]

@idgserpro this PR was merged, indeed setup.py needs to be updated too.

I will do it directly on master if it is ok for you @jensens ?

Gauthier

[idgserpro]

@gbastien It might also be interesting to put one:

Products.CMFPlone >=5.0

in install_requires.