Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone 4: Make patterns lib support optional. #85

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
3 participants
@jone
Copy link
Member

commented May 20, 2019

The Plone 4 version (1.3.x) did not work without require and patterns lib, although neither Plone 4 nor c.z.datagridfield installs patterns lib, nor is it documented in the readme.

This change simply makes the patterns lib support optional, so that it also work without patterns lib.

Make patterns lib support optional.
The Plone 4 version (1.3.x) did not work without require and patterns
lib, although neither Plone 4 nor c.z.datagridfield installs patterns
lib, nor is it documented in the readme.

This change simply makes the patterns lib support optional, so that
it also work without patterns lib.
@coveralls

This comment has been minimized.

Copy link

commented May 20, 2019

Pull Request Test Coverage Report for Build 291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.19%

Totals Coverage Status
Change from base Build 246: 0.0%
Covered Lines: 528
Relevant Lines: 693

💛 - Coveralls
@gbastien

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Hi @jone

we just had the same issue with @sverbois and this solves it for Plone 4.3.18

Gauthier

@gbastien gbastien merged commit 4e907e7 into 1.3.x May 22, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.19%
Details

@gbastien gbastien referenced this pull request May 22, 2019

Closed

Release 1.3.2 #86

@jone jone deleted the jone-1.3.x-no-patlib branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.