Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone 4: Make patterns lib support optional. #85

Merged
merged 1 commit into from May 22, 2019
Merged

Conversation

jone
Copy link
Member

@jone jone commented May 20, 2019

The Plone 4 version (1.3.x) did not work without require and patterns lib, although neither Plone 4 nor c.z.datagridfield installs patterns lib, nor is it documented in the readme.

This change simply makes the patterns lib support optional, so that it also work without patterns lib.

The Plone 4 version (1.3.x) did not work without require and patterns
lib, although neither Plone 4 nor c.z.datagridfield installs patterns
lib, nor is it documented in the readme.

This change simply makes the patterns lib support optional, so that
it also work without patterns lib.
@coveralls
Copy link

coveralls commented May 20, 2019

Pull Request Test Coverage Report for Build 291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.19%

Totals Coverage Status
Change from base Build 246: 0.0%
Covered Lines: 528
Relevant Lines: 693

💛 - Coveralls

@gbastien
Copy link
Member

Hi @jone

we just had the same issue with @sverbois and this solves it for Plone 4.3.18

Gauthier

@gbastien gbastien merged commit 4e907e7 into 1.3.x May 22, 2019
@gbastien gbastien mentioned this pull request May 22, 2019
@jone jone deleted the jone-1.3.x-no-patlib branch May 22, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants