Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: auto appending row #93

Merged
merged 2 commits into from Dec 29, 2019
Merged

Bug fix: auto appending row #93

merged 2 commits into from Dec 29, 2019

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Dec 6, 2019 •
edited

dataGridField2Functions.init() after DOM is loaded.
The call should stay in init_field.py for modals.
The setup is not elegant, but I do not change it as it works.
Fixes issue #92

@coveralls
Copy link

Pull Request Test Coverage Report for Build 325

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.276%
Totals Coverage Status
Change from base Build 322: 0.0%
Covered Lines: 1090
Relevant Lines: 1448
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 325

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.276%
Totals Coverage Status
Change from base Build 322: 0.0%
Covered Lines: 1635
Relevant Lines: 2172
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Dec 6, 2019 •
edited

Pull Request Test Coverage Report for Build 325

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.276%
Totals Coverage Status
Change from base Build 322: 0.0%
Covered Lines: 1635
Relevant Lines: 2172
💛 - Coveralls

@ksuess ksuess added the bug label Dec 6, 2019
@ksuess ksuess requested a review from Gomez December 6, 2019 16:42
@Gomez Gomez merged commit add614b into master Dec 29, 2019
@ksuess ksuess deleted the auto-append-row branch January 6, 2020 10:28
@ksuess ksuess restored the auto-append-row branch January 7, 2020 10:03
@ksuess ksuess deleted the auto-append-row branch January 7, 2020 10:12
@mauritsvanrees mauritsvanrees mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gomez Gomez Awaiting requested review from Gomez

@pbauer pbauer Awaiting requested review from pbauer

@tkimnguyen tkimnguyen Awaiting requested review from tkimnguyen

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksuess @coveralls @Gomez