Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenInputWidget breaks on editing for non-ASCII values #20

Closed
jsbueno opened this issue Jan 7, 2013 · 0 comments
Closed

TokenInputWidget breaks on editing for non-ASCII values #20

jsbueno opened this issue Jan 7, 2013 · 0 comments
Labels
bug

Comments

@jsbueno
Copy link
Member

jsbueno commented Jan 7, 2013

Example If any of the tags contains non-ASCII chars, the edit view will explode with an 馃憤 UnicodeDecodeError - the current code incorrectly mixes unicode and strings --
(The presence of a "unicode(value, errors="ignore") line is an indicator that something is deadly wrong on the current code.

Example Traceback:
http://pastie.org/5643171

I am formating a patch to deal with the issue.
@jsbueno jsbueno mentioned this issue Jan 7, 2013
Merged
hvelarde added a commit that referenced this issue Jan 8, 2013
@hvelarde
Merge pull request #21 from jsbueno/master
b08ea24 
Fixes  mixed unicode and strings for editing, fixes issue #20
@hvelarde hvelarde closed this as completed Jan 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvelarde @jsbueno