Refs #19535 EEA; Added delimiter restrictions to CSV dialect detection

collective · May 12, 2014 · 90ee10c · 90ee10c
1 parent c7cae92
commit 90ee10c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/docs/HISTORY.txt b/docs/HISTORY.txt
@@ -3,6 +3,9 @@ Changelog
 
 8.5-dev - (unreleased)
 ----------------------
+* Bug fix: Added delimiter restrictions to CSV dialect detection. Valid CSV 
+  delimiters are: {tab}, {space}, ;, ,, :
+  [olimpiurob refs #19535]
 * Feature: Added test for missing values in json boolean fields and downloading
   as tsv
   [olimpiurob refs #19206]

diff --git a/eea/app/visualization/converter/converter.py b/eea/app/visualization/converter/converter.py
@@ -54,7 +54,8 @@ def dialect(self, datafile):
         datafile.seek(0)
         sniffer = csv.Sniffer()
         try:
-            dialect = sniffer.sniff(datafile.read(2048))
+            dialect = sniffer.sniff(datafile.readline(2048),
+                                    delimiters='\t ;,:')
         except Exception, err:
             logger.debug(err)
             dialect = 'eea-tab'