Refactoring the createWebsocket Event

[iFlameing]

@datakurre I made a separate function for createwebsocketevent. We have to pass lots of arguments to the functions. I also refactor the updatePloneCollection function But somehow I am not able to update the plone collection because it is giving me an error

  TypeError: getNodes is not a function

Can you point out what I am missing? Or some better way to refactor the code

[coveralls]

Pull Request Test Coverage Report for Build 767

• 2 of 22 (9.09%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 37.752%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/gatsby-node.js	2	22	9.09%

Totals
Change from base Build 763:	0.2%
Covered Lines:	139
Relevant Lines:	351

---

💛 - Coveralls

[iFlameing]

I am not feeling very good about this refactoring. It will reduce the noise but it is not looking good to me. we hardly saving any line :(

[datakurre]

@iFlameing Did you find and fix the issue you had with collection update? I guess you did, because this is now green.

For me this looks good. It does not matter that you don't save any lines. It's more important to "flatten" the code into smaller functions.

Once that's done, you could think about splitting these huge "utils.js" and "gatsby-node.js" files into smaller meaningful files (with matching tests files).

All this will make it easier to do typescript reafactoring later.

Single option to "reduce lines" would be to keep passing single "options" object instead of separate parameters, but I would like to do that only in typescript. Then typescript would project that no options are missing.

[iFlameing]

@datakurre Yes! After some experiminting, I am able to fix it :)