Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with latest python-dateutil #260

Closed
jensens opened this issue Apr 3, 2018 · 7 comments
Closed

Problems with latest python-dateutil #260

jensens opened this issue Apr 3, 2018 · 7 comments
Labels

Comments

@jensens
Copy link
Member

jensens commented Apr 3, 2018

I tried to update our Plone dependencies to python-dateutil 2.7.2 which broke, see plone/buildout.coredev#447

I found it is an icalendar issue. Also icalendar Travis CI https://travis-ci.org/collective/icalendar/builds/361592061is red.

@jensens jensens added the blocker label Apr 3, 2018
@kyrias
Copy link

kyrias commented Jun 30, 2018

Reading RFC 5545 a bit closer it seems that the dateutil exception is misleading, and it's the test case that's wrong.

RFC 5545 ¶3.3.10

                                             Furthermore, if the
      "DTSTART" property is specified as a date with local time, then
      the UNTIL rule part MUST also be specified as a date with local
      time.  If the "DTSTART" property is specified as a date with UTC
      time or a date with local time and time zone reference, then the
      UNTIL rule part MUST be specified as a date with UTC time.  In the
      case of the "STANDARD" and "DAYLIGHT" sub-components the UNTIL
      rule part MUST always be specified as a date with UTC time.

While this is the actual test data that fails, where UNTIL is in UTC (which it has to be since it's a DAYLIGHT sub-component), but DTSTART doesn't specify the timezone so is in local time, which is invalid as per the RFC above.

@legrostdg
Copy link

legrostdg commented Oct 9, 2018

What is the recommendation for this test? Should it be disabled? python-icalendar (and its reverse dependencies) will be removed from Debian testing soon (on 2018-10-24)... https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908498

@jensens
Copy link
Member Author

jensens commented Oct 9, 2018

This is solved for now, follow up see #274

@legrostdg
Copy link

Would it be possible to do a new release with this fix? This would help Debian packaging. Thanks!

@jensens
Copy link
Member Author

jensens commented Oct 9, 2018

@esteele @mauritsvanrees @thet can we have a release of the latest fixes please?

@mauritsvanrees
Copy link
Member

There you go: https://pypi.org/project/icalendar/4.0.3/

@legrostdg
Copy link

Great, thanks!

svenstaro pushed a commit to archlinux/svntogit-community that referenced this issue Jul 22, 2020
collective/icalendar#260

git-svn-id: file:///srv/repos/svn-community/svn@351447 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants