Introduce Hypothesis for testing #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
force-pushed
the
hypothesis-fuzzing
branch
2 times, most recently
from
2446de7
to
583ee65
Compare
|
This validator based on ical4j seems to explicitly reject that character during parsing: http://severinghaus.org/projects/icv/ While this one isn't bothered at all: http://icalendar.org/component/com_icalvalidator/Itemid,150/view,validator/ |
untitaker
force-pushed
the
hypothesis-fuzzing
branch
6 times, most recently
from
dc13bd5
to
5c02e01
Compare
|
I've read the RFC again and it appears that the unicode line separator must not be treated as one. I fixed that bug, so this PR is now ready for review. |
geier
approved these changes
Jan 30, 2017
untitaker
force-pushed
the
hypothesis-fuzzing
branch
from
5c02e01
to
c764db3
Compare
UniversalSuperBox
added a commit
that referenced
this pull request
Nov 12, 2019
The fuzzing configuration introduced by #191 *did* find a novel issue in its first run. However, it is unable to run on travis-ci due to taking too long without output. I tried running it locally to make sure it wasn't Travis being Travis, and sure enough, on my i9-9880H, the operation took well over 20 minutes before I stopped it. Because of this, I've reduced the number of examples that Hypothesis will run. This will catch fewer errors but help us get PRs back on track
Merged
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Nov 12, 2019
Branch: refs/heads/master Date: 2019-11-12T10:47:14-06:00 Author: Dalton Durst (UniversalSuperBox) <d@ltondur.st> Commit: collective/icalendar@b6f211d Calm down fuzzing The fuzzing configuration introduced by collective/icalendar#191 *did* find a novel issue in its first run. However, it is unable to run on travis-ci due to taking too long without output. I tried running it locally to make sure it wasn't Travis being Travis, and sure enough, on my i9-9880H, the operation took well over 20 minutes before I stopped it. Because of this, I've reduced the number of examples that Hypothesis will run. This will catch fewer errors but help us get PRs back on track Files changed: M CHANGES.rst M docs/credits.rst M src/icalendar/tests/hypothesis/test_fuzzing.py Repository: icalendar Branch: refs/heads/master Date: 2019-11-12T12:35:25-06:00 Author: Dalton Durst (UniversalSuperBox) <github@daltondur.st> Commit: collective/icalendar@165b4e4 Merge pull request #296 from collective/less-fuzzing Calm down fuzzing Files changed: M CHANGES.rst M docs/credits.rst M src/icalendar/tests/hypothesis/test_fuzzing.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Nov 12, 2019
Branch: refs/heads/master Date: 2019-11-12T10:47:14-06:00 Author: Dalton Durst (UniversalSuperBox) <d@ltondur.st> Commit: collective/icalendar@b6f211d Calm down fuzzing The fuzzing configuration introduced by collective/icalendar#191 *did* find a novel issue in its first run. However, it is unable to run on travis-ci due to taking too long without output. I tried running it locally to make sure it wasn't Travis being Travis, and sure enough, on my i9-9880H, the operation took well over 20 minutes before I stopped it. Because of this, I've reduced the number of examples that Hypothesis will run. This will catch fewer errors but help us get PRs back on track Files changed: M CHANGES.rst M docs/credits.rst M src/icalendar/tests/hypothesis/test_fuzzing.py Repository: icalendar Branch: refs/heads/master Date: 2019-11-12T12:35:25-06:00 Author: Dalton Durst (UniversalSuperBox) <github@daltondur.st> Commit: collective/icalendar@165b4e4 Merge pull request #296 from collective/less-fuzzing Calm down fuzzing Files changed: M CHANGES.rst M docs/credits.rst M src/icalendar/tests/hypothesis/test_fuzzing.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reveals a failure: The character
\u2028in a value is silently discarded. A quicklook at the iCalendar RFC didn't make it obvious that this character wouldn't
be allowed.