Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor test_unicode_param #478

Merged
merged 2 commits into from
Oct 29, 2022
Merged

refactor test_unicode_param #478

merged 2 commits into from
Oct 29, 2022

Conversation

jacadzaca
Copy link
Collaborator

refactoring of test_property_params

niccokunzmann
niccokunzmann approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@niccokunzmann niccokunzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! The lines of code were reduced down a lot and previous tests re-used.

@niccokunzmann
Copy link
Member

Can you merge it?

@niccokunzmann niccokunzmann merged commit 0607510 into collective:master Oct 29, 2022
@niccokunzmann
Copy link
Member

Hihi thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niccokunzmann niccokunzmann niccokunzmann approved these changes

@angatha angatha Awaiting requested review from angatha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacadzaca @niccokunzmann