Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 350 #616

Merged
merged 3 commits into from
May 20, 2024
Merged

Issue 350 #616

merged 3 commits into from
May 20, 2024

Conversation

natashamm
Copy link
Contributor

Fixes #350

Parse calendars with X-COMMENT properties at the end of an icalendar file. The solution is to simply not parse the properties occurring outside of the calendar.

For example with this calendar:

BEGIN:VCALENDAR
...
END:VCALENDAR
X-COMMENT:Hi

We will not parse the X-COMMENT.

@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9154563017

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.007%) to 96.706%

Files with Coverage Reduction New Missed Lines %
src/icalendar/tests/test_cli_tool.py 2 88.0%
src/icalendar/tests/test_timezoned.py 2 99.03%
src/icalendar/tests/conftest.py 2 96.33%
Totals Coverage Status
Change from base Build 8956565066: 0.007%
Covered Lines: 2760
Relevant Lines: 2854

💛 - Coveralls

@niccokunzmann
Copy link
Member

Thanks! This is nice.

@niccokunzmann niccokunzmann merged commit 9e3b686 into collective:master May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore X-... properties also at end of file?
3 participants