Plone 6 and pas.plugin.oidc compatibility #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration isn't compatible with Plone 6. When included, an error is rendered in the viewlet.
damilgra
changed the title
damilgra
changed the title
This was referenced Nov 3, 2023
ale-rt
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Thanks for your contribution!
If you have valid reasons to remove the viewlet, please do that in a separate PR.
As described by the package README, you can achieve the same result by running this code:
from iw.rejectanonymous import addValidIds
...
addValidIds('callback')
| manager="plone.app.layout.viewlets.interfaces.IPortalHeader" | ||
| class="plone.app.layout.viewlets.common.PersonalBarViewlet" | ||
| permission="cmf.SetOwnProperties" | ||
| /> |
There was a problem hiding this comment.
I do not see why you need to remove the personal bar viewlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds 'callback' as a valid ID, ensuring compatibility with pas.plugin.oidc.
Otherwise, a site configured with both iw.rejectanonymous and pas.plugin.oidc leads to a login redirect cycle.