Merge pull request #25 from collective/sneridagh_fix_enumerateusers

Temptative to fix the bug in enumerateUsers where always is returning…

CHANGES.rst

@@ -4,7 +4,9 @@ Changelog
 1.0a8 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Fix filter users bug in enumerateUsers plugin where it was always returning
+  all the users.
+  [sneridagh]
 
 
 1.0a7 (2016-02-15)

plone-4.3.x.cfg

@@ -1,10 +1,9 @@
 [buildout]
 extends =
     base.cfg
-    http://dist.plone.org/release/4.3.7/versions.cfg
+    http://dist.plone.org/release/4.3.9/versions.cfg
     versions.cfg
 
 [versions]
 plone.protect = 3.0.16
 zest.releaser =
-

src/pas/plugins/authomatic/plugin.py

@@ -224,6 +224,8 @@ def enumerateUsers(self, id=None, login=None, exact_match=False,
         if search_id:
             if not isinstance(search_id, basestring):
                 raise NotImplementedError('sequence is not supported.')
+        else:
+            return ()
 
         pluginid = self.getId()
         ret = list()

src/pas/plugins/authomatic/tests/test_plugin.py

@@ -86,8 +86,10 @@ def test_user_enumaration(self):
             2,
             len(self.plugin.enumerateUsers(login='123wil'))
         )
-        # list all!
+        # https://github.com/collective/pas.plugins.authomatic/pull/25/commits/5c0f6b1dc76a0d769e35a845ce4c4dd4307655ba
+        # Due to the workarround, now the enumerateUsers plugin doesn't return
+        # any users when searching with an empty query
         self.assertEqual(
-            4,
+            0,
             len(self.plugin.enumerateUsers())
         )