-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
determine whether to use croppinginfo or autocropped scales #30
Comments
well not only listings of course :) |
for the record: i'm using https://github.com/collective/archetypes.clippingimage for automatically cropped scales as a workaround in one project. it only supports AT (afaik) and only image access via image_ traverser (might be easy to solve), though. as - contrary to the promise (make this package as minimally invasive as possible) in the readme - we already started to overwrite plone.app.imaging's views in this package i'd rather go and add auto-crop support there too (maybe in a separate package that can be activated by an extra eg |
so this would solve my issue as described nearly 2 years ago ... af16f89 |
so "autodown" will use the predefined crop now, if it exists? |
Yep... But right now only for dexterity content types. |
I'm rethinking this today ... maybe it's better to override the 'down' direction, so integrators don't have to adapt existing templates. The main purpose of the 'down' direction is for cropping, so if we get a p.a.imagecropping cropped scale we can savely deliver it instead of standard 'down' behavior ... @frisi @agitator your opinions? |
cool! yes, was thinking why the extra option - would use the manual crop first if exists and the automatic crop as fallback |
yep ... see #66 |
nice! i'll buy you a beer in Bucharest ;-) |
👍 abgmacht :) |
i think it's perfectly fine to re-use the 'down' direction and deliver a crop defined by plone.app.imagecropping if it has been defined. i'll comment on PR #66 |
if you have a listing with auto cropped scales (eg: scales.scale("image", scale="mini", direction="down") and you want to crop only one image of those, you can't, because the autocropping direction="down" will override the saved cropped scale.
The text was updated successfully, but these errors were encountered: