determine whether to use croppinginfo or autocropped scales #30

Closed
petschki opened this Issue Sep 23, 2013 · 11 comments

Comments

Projects
None yet
3 participants
@petschki
Member

petschki commented Sep 23, 2013

if you have a listing with auto cropped scales (eg: scales.scale("image", scale="mini", direction="down") and you want to crop only one image of those, you can't, because the autocropping direction="down" will override the saved cropped scale.

@petschki

This comment has been minimized.

Show comment
Hide comment
@petschki

petschki Sep 23, 2013

Member

well not only listings of course :)

Member

petschki commented Sep 23, 2013

well not only listings of course :)

@frisi

This comment has been minimized.

Show comment
Hide comment
@frisi

frisi Jan 21, 2015

Member

for the record: i'm using https://github.com/collective/archetypes.clippingimage for automatically cropped scales as a workaround in one project.

it only supports AT (afaik) and only image access via image_ traverser (might be easy to solve), though.

as - contrary to the promise (make this package as minimally invasive as possible) in the readme - we already started to overwrite plone.app.imaging's views in this package i'd rather go and add auto-crop support there too (maybe in a separate package that can be activated by an extra eg plone.app.imagecropping[autocrop])

Member

frisi commented Jan 21, 2015

for the record: i'm using https://github.com/collective/archetypes.clippingimage for automatically cropped scales as a workaround in one project.

it only supports AT (afaik) and only image access via image_ traverser (might be easy to solve), though.

as - contrary to the promise (make this package as minimally invasive as possible) in the readme - we already started to overwrite plone.app.imaging's views in this package i'd rather go and add auto-crop support there too (maybe in a separate package that can be activated by an extra eg plone.app.imagecropping[autocrop])

@petschki

This comment has been minimized.

Show comment
Hide comment
@petschki

petschki Aug 17, 2015

Member

so this would solve my issue as described nearly 2 years ago ... af16f89

Member

petschki commented Aug 17, 2015

so this would solve my issue as described nearly 2 years ago ... af16f89

@agitator

This comment has been minimized.

Show comment
Hide comment
@agitator

agitator Aug 17, 2015

Member

so "autodown" will use the predefined crop now, if it exists?

Member

agitator commented Aug 17, 2015

so "autodown" will use the predefined crop now, if it exists?

@petschki

This comment has been minimized.

Show comment
Hide comment
@petschki

petschki Aug 17, 2015

Member

Yep... But right now only for dexterity content types.

Member

petschki commented Aug 17, 2015

Yep... But right now only for dexterity content types.

@petschki

This comment has been minimized.

Show comment
Hide comment
@petschki

petschki Aug 18, 2015

Member

I'm rethinking this today ... maybe it's better to override the 'down' direction, so integrators don't have to adapt existing templates. The main purpose of the 'down' direction is for cropping, so if we get a p.a.imagecropping cropped scale we can savely deliver it instead of standard 'down' behavior ... @frisi @agitator your opinions?

Member

petschki commented Aug 18, 2015

I'm rethinking this today ... maybe it's better to override the 'down' direction, so integrators don't have to adapt existing templates. The main purpose of the 'down' direction is for cropping, so if we get a p.a.imagecropping cropped scale we can savely deliver it instead of standard 'down' behavior ... @frisi @agitator your opinions?

@agitator

This comment has been minimized.

Show comment
Hide comment
@agitator

agitator Aug 18, 2015

Member

cool!

yes, was thinking why the extra option - would use the manual crop first if exists and the automatic crop as fallback

Member

agitator commented Aug 18, 2015

cool!

yes, was thinking why the extra option - would use the manual crop first if exists and the automatic crop as fallback

@petschki

This comment has been minimized.

Show comment
Hide comment
@petschki

petschki Aug 18, 2015

Member

yep ... see #66

Member

petschki commented Aug 18, 2015

yep ... see #66

@agitator

This comment has been minimized.

Show comment
Hide comment
@agitator

agitator Aug 18, 2015

Member

nice! i'll buy you a beer in Bucharest ;-)

Member

agitator commented Aug 18, 2015

nice! i'll buy you a beer in Bucharest ;-)

@petschki

This comment has been minimized.

Show comment
Hide comment
@petschki

petschki Aug 18, 2015

Member

👍 abgmacht :)

Member

petschki commented Aug 18, 2015

👍 abgmacht :)

@frisi

This comment has been minimized.

Show comment
Hide comment
@frisi

frisi Aug 18, 2015

Member

i think it's perfectly fine to re-use the 'down' direction and deliver a crop defined by plone.app.imagecropping if it has been defined. i'll comment on PR #66

Member

frisi commented Aug 18, 2015

i think it's perfectly fine to re-use the 'down' direction and deliver a crop defined by plone.app.imagecropping if it has been defined. i'll comment on PR #66

@petschki petschki closed this in 2858823 Aug 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment