Merge 2506578 into 422831a

collective · Oct 17, 2018 · 674ef73 · 674ef73
2 parents 422831a + 2506578
commit 674ef73
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -5,6 +5,7 @@ Changelog
 1.1 (unreleased)
 ----------------
 
+- Quote url path when setting cookie
 - Fix email tests and travis tests
   [instification]
 

diff --git a/redomino/tokenrole/tokenroleprovider.py b/redomino/tokenrole/tokenroleprovider.py
@@ -119,8 +119,7 @@ def getRoles(self, principal_id):
             if expire_date.replace(tzinfo=None) > datetime.now():
                 if token not in request.cookies:
                     physical_path = self.context.getPhysicalPath()
-                    # Is there a better method for calculate the url_path?
-                    url_path = '/' + '/'.join(request.physicalPathToVirtualPath(physical_path))
+                    url_path = urllib.quote('/' + '/'.join(request.physicalPathToVirtualPath(physical_path)))
                     response.setCookie(name='token',
                                        value=token,
                                        expires=DateTime(expire_date).toZone('GMT').rfc822(),