Use urllib import from six

collective · Jan 4, 2019 · ce23c72 · ce23c72
1 parent cffbc14
commit ce23c72
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -30,3 +30,4 @@ nosetests.xml
 
 #Mr Developer
 .mr.developer.cfg
+/.vscode/settings.json
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -5,7 +5,8 @@ Changelog
 1.2 (unreleased)
 ----------------
 
-- Nothing changed yet.
+- Fixed missing urllib import with Python3 compatible import and add six as dependency
+  [MrTango]
 
 
 1.1 (2018-10-17)

diff --git a/redomino/tokenrole/tokenroleprovider.py b/redomino/tokenrole/tokenroleprovider.py
@@ -22,6 +22,7 @@
 from redomino.tokenrole.interfaces import ITokenRolesAnnotate
 from redomino.tokenrole.interfaces import ITokenInfoSchema
 from redomino.tokenrole.interfaces import ITokenRolesProviding
+from six.moves import urllib
 from zope.annotation.interfaces import IAnnotations
 from zope.component import adapter
 from zope.globalrequest import getRequest
@@ -33,7 +34,6 @@
     def safeWrite(context, request=None):
         return
 
-import urllib
 
 
 ANNOTATIONS_KEY = 'redomino.tokenrole.tokenrole_annotations'

diff --git a/setup.py b/setup.py
@@ -43,6 +43,7 @@
         'Products.validation',
         'setuptools',
         'z3c.jbot',
+        'six',
     ],
     extras_require={
         'test': [