Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quote from six.moves.urllib.parse since six.moves.urllib has no attribute/function quote. #23

Merged
merged 1 commit into from Aug 11, 2020

Conversation

adrianschulz
Copy link

I noticed that it's not possible to access a page with the token-URL because you get the following error message.

Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 156, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 338, in publish_module
  Module ZPublisher.WSGIPublisher, line 244, in publish
  Module ZPublisher.BaseRequest, line 627, in traverse
  Module Products.PluggableAuthService.PluggableAuthService, line 263, in validate
  Module Products.PluggableAuthService.PluggableAuthService, line 826, in _authorizeUser
  Module Products.PlonePAS.plugins.ufactory, line 192, in allowed
  Module plone.memoize.volatile, line 73, in replacement
  Module borg.localrole.workspace, line 476, in checkLocalRolesAllowed
  Module redomino.tokenrole.tokenroleprovider, line 124, in getRoles
AttributeError: module 'six.moves.urllib' has no attribute 'quote'

Since this is part of the migration to Python3 (with Plone5.2) I suggest merging it into the plone52-Branch.

Would you mind reviewing my change @tomgross ?

@coveralls
Copy link

coveralls commented Aug 11, 2020

Coverage Status

Coverage remained the same at 70.022% when pulling 5be78be on six-moves-urllib-quote into 41f4e9c on plone52.

@tomgross
Copy link
Member

According to the documentation (https://six.readthedocs.io/#module-six.moves.urllib.parse) this looks like the right thing to do. Thanks @adrianschulz !

@tomgross tomgross merged commit 4288f5c into plone52 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants