Skip to content

Commit

Permalink
Add missing upgrade step
Browse files Browse the repository at this point in the history
  • Loading branch information
hvelarde committed Jan 5, 2017
1 parent 60d8d76 commit bbc3fc0
Show file tree
Hide file tree
Showing 7 changed files with 37 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ There's a frood who really knows where his towel is.
2.6rc1 (unreleased)
^^^^^^^^^^^^^^^^^^^

- Add missing upgrade step to cook CSS resources.
[hvelarde]

- Don't fail in the Twitter plugin if the title has non-ASCII characters.
[csenger, hvelarde]

Expand Down
2 changes: 1 addition & 1 deletion sc/social/like/profiles/default/metadata.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0"?>
<metadata>
<version>3041</version>
<version>3042</version>
</metadata>
11 changes: 11 additions & 0 deletions sc/social/like/tests/test_upgrades.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,14 @@ def test_register_cover_tiles(self):

registered = api.portal.get_registry_record('plone.app.tiles')
[self.assertIn(t, registered) for t in TILES]


class To3042TestCase(UpgradeTestCaseBase):

def setUp(self):
UpgradeTestCaseBase.setUp(self, u'3041', u'3042')

def test_upgrade_to_3042_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 1)
4 changes: 2 additions & 2 deletions sc/social/like/upgrades/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
from sc.social.like.logger import logger


def cook_css_resources(context):
def cook_css_resources(context): # pragma: no cover
"""Cook css resources."""
css_tool = api.portal.get_tool('portal_css')
css_tool.cookResources()
logger.info('CSS resources were cooked')


def cook_javascript_resources(context):
def cook_javascript_resources(context): # pragma: no cover
"""Cook javascript resources."""
js_tool = api.portal.get_tool('portal_javascripts')
js_tool.cookResources()
Expand Down
1 change: 1 addition & 0 deletions sc/social/like/upgrades/configure.zcml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
<include package=".v3030" />
<include package=".v3040" />
<include package=".v3041" />
<include package=".v3042" />

</configure>
1 change: 1 addition & 0 deletions sc/social/like/upgrades/v3042/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# -*- coding:utf-8 -*-
18 changes: 18 additions & 0 deletions sc/social/like/upgrades/v3042/configure.zcml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<configure
xmlns="http://namespaces.zope.org/zope"
xmlns:genericsetup="http://namespaces.zope.org/genericsetup">

<genericsetup:upgradeSteps
source="3041"
destination="3042"
profile="sc.social.like:default">

<genericsetup:upgradeStep
title="Cook CSS resources"
description="There were changes in the CSS files, so we need to cook the resources."
handler="..cook_css_resources"
/>

</genericsetup:upgradeSteps>

</configure>

0 comments on commit bbc3fc0

Please sign in to comment.