Fix Canonical URL updater form #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new upgrade step is also provided to update the objects_provides catalog index.
We need to find out where to open an issue about this.
hvelarde
commented
Jul 20, 2017
|
|
||
| def test_upgrade_to_3046_registrations(self): | ||
| version = self.setup.getLastVersionForProfile(self.profile_id)[0] | ||
| self.assertGreaterEqual(int(version), int(self.to_version)) |
rodfersou
reviewed
Jul 21, 2017
| @@ -42,11 +30,12 @@ class ICanonicalURLUpdater(model.Schema): | |||
| constraint=validate_canonical_domain, | |||
| ) | |||
|
|
|||
| created_before = schema.Date( | |||
| published_before = schema.Date( | |||
There was a problem hiding this comment.
I miss the 'date' name in this attribute, how about to change it to 'published_before_date'?
|
I opened this thread on the community forum to find a solution to the error in Plone 5.1: https://community.plone.org/t/strange-catalog-behavior-on-plone-5-1/4582?u=hvelarde |
rodfersou
reviewed
Jul 25, 2017
| @@ -23,21 +24,31 @@ def setUp(self): | |||
| self.portal = self.layer['portal'] | |||
| self.request = self.layer['request'] | |||
| enable_social_media_behavior() | |||
| self.setup_content() | |||
| api.portal.set_registry_record( | |||
| name='canonical_domain', value='https://example.org', interface=ISocialLikeSettings) | |||
There was a problem hiding this comment.
I thought canonical_domain becomes old_canonical_domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new upgrade step is also provided to update the
objects_providescatalog index.WIP
fixes: #115