Update widgets, refactor and code clean up #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
force-pushed
the
hvelarde-cleanup
branch
from
f8a2be0
to
72270a8
Compare
Clean up and refactor. More information: * https://developer.linkedin.com/plugins/share * https://developer.linkedin.com/docs/share-on-linkedin
We need support for default value in get_registry_record(). Also, remove unnecessary [blobs] extra on plone.namedfile.
hvelarde
force-pushed
the
hvelarde-cleanup
branch
from
72270a8
to
5cddc29
Compare
rodfersou
reviewed
Sep 5, 2017
|
|
||
| # TODO: check if Pinterest can use Open Graph instead |
There was a problem hiding this comment.
Actually Pinterest uses Open Graph; This method is used just when DnT is activated, the image url needs to be sent as parameter to Pinterest.
There was a problem hiding this comment.
ok, I'm going to make some more changes according to that.
Clean up and refactor. More information: * https://developers.pinterest.com/docs/widgets/save/ * https://developers.pinterest.com/docs/rich-pins/reference/
Clean up and refactor. More information: * https://developers.google.com/+/web/share/
hvelarde
force-pushed
the
hvelarde-cleanup
branch
from
5cddc29
to
0cf9080
Compare
This was referenced Sep 5, 2017
idgserpro
reviewed
Sep 5, 2017
There was a problem hiding this comment.
You didn't even give time to us to review, rs. But looks good, specially the plone.api upgrade to avoid InvalidParameterError checks all over the place.
typebutton used to persist 'horizontal' but now you only check for 'vertical', you don't need an upgradStep here, right?
|
we need to finish it this week :-) no, in fact I want to get rid of that at some point as is a collections of hacks: all plugins treat it on a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make plugins faster and consume less memory.
refs. #117