CookieLaw and enhanced privacy settings #54
Conversation
Some tests with facebook
| @@ -6,6 +6,12 @@ There's a frood who really knows where his towel is. | |||
| 2.3 (unreleased) | |||
| ^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - Flake8 cleanup | |||
There was a problem hiding this comment.
IMO, changelog entries should provide useful information for end users, developers and integrators; Flake8 fixes doesn't fall under this... but that's only MO.
There was a problem hiding this comment.
@hvelarde no opposition about this, is not really useful.
It take me one minute for remove the entry
|
|
||
|
|
||
| def add_privacy_setting(context): | ||
| ''' Apply upgrade profile ''' |
There was a problem hiding this comment.
triple double quotes in docstrings, please
|
@keul nice work! the only thing I would love to change in the name and description of the field... I think In the future we probably want to split this feature out of this package. also I've seen this implemented in some European news sites with a small enhancement: showing a small dialog when you visit their sites telling you that they are using cookies; we could do the same later.
|
|
@hvelarde if you can find a better name for the field I can change it! I simply didn't find any better option. About the global warning: we use it too, but in another package (because "social" is not the only possible cookie origin) but this is a different (and complex) argument as every EU country interpreted the law in a different way. |
|
Still left:
|
| xmlns:gs="http://namespaces.zope.org/genericsetup" | ||
| i18n_domain="sc.social.like"> | ||
|
|
||
| <gs:registerProfile |
There was a problem hiding this comment.
I think we also need to hide this profile
|
@hvelarde hidden |
| @@ -72,6 +72,19 @@ class IProvidersSchema(Interface): | |||
| vocabulary=styles, | |||
| ) | |||
|
|
|||
| privacy = schema.Bool( | |||
There was a problem hiding this comment.
what about avoid_tracking of do_not_track?
@agnogueira @rodfersou comments?
|
@hvelarde thanks for contributing, give me some days to check those changes. |
Change from "privacy" to "Do not track"
|
@hvelarde I used the do_not_track version (hoping this will be the final choice) |
CookieLaw and enhanced privacy settings
|
@keul awesome! could you please update the changelog on the master branch to reflect better what was done? don't hesitate on adding a whole paragraph. after that we can make a release if you need it. |
|
@hvelarde I added few words in the CHANGES file, just because I already added a new whole section in the main README. Feel free to extend/fix it! If you can spread a new release, it will be great. |
See #51