Issue 65 - Add Twitter Cards metadata #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodfersou
force-pushed
the
issue_65
branch
3 times, most recently
from
9167985
to
d0276d8
Compare
| @@ -35,6 +38,7 @@ def __init__(self, context, request): | |||
| self.url = context.absolute_url() | |||
| self.language = get_language(context) | |||
| self.sheet = getattr(pp, 'sc_social_likes_properties', None) | |||
| self.image = get_content_image(context, width=1200, height=630) | |||
There was a problem hiding this comment.
@rodfersou why are you hardcoding this with those valued?
rodfersou
force-pushed
the
issue_65
branch
5 times, most recently
from
faa0758
to
2934378
Compare
rodfersou
force-pushed
the
issue_65
branch
2 times, most recently
from
5ae3901
to
5cac285
Compare
hvelarde
force-pushed
the
issue_65
branch
3 times, most recently
from
ad90dfb
to
595cc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65