Fix test fixture not to fail in Plone 5 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
force-pushed
the
hvelarde-plone5
branch
from
0f57c45
to
bb78568
Compare
hvelarde
changed the title
hvelarde
force-pushed
the
hvelarde-plone5
branch
from
bb78568
to
dd78913
Compare
hvelarde
force-pushed
the
hvelarde-plone5
branch
from
8592091
to
51ab89b
Compare
|
@rodfersou preciso sua ajuda para consertar os 2 testes que estão falhando. |
|
@hvelarde green \o/ |
hvelarde
commented
Jan 23, 2017
| @@ -34,7 +34,6 @@ Create Document | |||
| Click Add Document | |||
| Input Text css=${title_selector} ${title} | |||
| Click Button Save | |||
| Page Should Contain Changes saved. | |||
There was a problem hiding this comment.
@rodfersou in Plone 5 we don't have status messages?
There was a problem hiding this comment.
@hvelarde yes, but the text change to Item created
There was a problem hiding this comment.
but why you removed this check?
There was a problem hiding this comment.
to don't break the test when we have p.a.contenttypes installed
There was a problem hiding this comment.
it looks like without p.a.contenttypes the text still is Item created, added back this check to see when it will break
There was a problem hiding this comment.
@hvelarde like I said it breaks.. what do you suggest?
rodfersou
force-pushed
the
hvelarde-plone5
branch
2 times, most recently
from
5c86e0f
to
cddb738
Compare
rodfersou
approved these changes
Jan 25, 2017
hvelarde
force-pushed
the
hvelarde-plone5
branch
2 times, most recently
from
c49e609
to
3f7503d
Compare
hvelarde
force-pushed
the
hvelarde-plone5
branch
from
3f7503d
to
f3948a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.