Dexterity, Author, requests #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
reviewed
Nov 23, 2018
There was a problem hiding this comment.
thanks for taking care of this; if I were the owner of the package I would say to you the following:
- you're taking care of too many things on one pull request, that's bad for code review
- you're not grouping commits on a logical way and that would be bad for the commit history
- you seem to be deprecating support for Plone 4.3, are you sure we can't avoid that?
I let the final decision to @davisagli as he's the father of the creature.
|
I'll split this pull request in at least two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of dexterity content types.
Use module requests instead of urllib2.
Author: insert info about id and display name