Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat):The first working version of the addon #1

Merged
merged 32 commits into from
Nov 16, 2022
Merged

(feat):The first working version of the addon #1

merged 32 commits into from
Nov 16, 2022

Conversation

dobri1408
Copy link
Contributor

@dobri1408 dobri1408 commented Nov 8, 2022

This is the addon that will be used to integrate sentry in volto projects.
You have to set a .env file where you give these values, in order to make the addon work
SENTRY_URL= sentry url
AUTH_TOKEN=auth token
SENTRY_ORG=organization slug
SENTRY_PROJECT=project slug
SENTRY_RELEASE=release version
SENTRY_DSN=dsn

@@ -21,6 +21,22 @@ module.exports = {
options: { pluginOptions, razzleOptions, webpackOptions },
paths,
}) {
if (
process.env.RAZZLE_SENTRY_AUTH_TOKEN &&
Copy link
Member

@avoinea avoinea Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As all RAZZLE_ environment variables are exposed also to the client window.env. we should consider renaming this sensitive env and not expose it to the client.

scope.setExtras({
action,
state: store.getState(),
const crashReporter = (middlewares) => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the old style, as a pure Redux middleware. Don't reference the middlewares in this module.

The reason is: we want to keep, as far as possible the "Volto domain" and "Redux domain" clean and separate, to make it easier to reason about them.

Copy link
Member

@avoinea avoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dobri1408 Please add README describing how to install this add-on and how to configure it via environment variables.

@avoinea
Copy link
Member

avoinea commented Nov 11, 2022

@dobri1408 You can take the existing documentation from older versions of @plone/volto and adapt it.

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Markdown syntax improvements, English grammar fixes, link to Sentry.io, and proper casing of Volto and Sentry.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
dobri1408 and others added 3 commits November 11, 2022 14:02
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
dobri1408 and others added 13 commits November 13, 2022 23:22
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add helpful link

readme.md Outdated Show resolved Hide resolved
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/sentry.js Outdated Show resolved Hide resolved
@tiberiuichim
Copy link
Member

@dobri1408 Have you tested the addon? Does it work as expected?

@dobri1408
Copy link
Contributor Author

@dobri1408 Have you tested the addon? Does it work as expected?

The source maps are uploaded, but for some reason, sentry does not show correctly where the React code error occurred, so the source maps are still an issue. I am trying to understand why this is happening. I tried many ways, but none of them worked.

@avoinea avoinea merged commit 0cd58f4 into main Nov 16, 2022
@avoinea avoinea deleted the ionut branch November 16, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants