Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependence on rails 3.0.3 is a problem for the new 3.0.4 security release #44

Closed
twalpole opened this issue Feb 8, 2011 · 7 comments
Closed

Comments

@twalpole
Copy link

twalpole commented Feb 8, 2011

Rails 3.0.4 was released to fix a couple of security issues. acts_as_audited declares 3.0.3 as a dependency can this be changed to >=3.0.3 if 3.0.3 minimum is actually required or ~> 3.0 if just rails 3 is required

@spovich
Copy link

spovich commented Feb 9, 2011

+1 Gems shouldn't declare a hard dependency like that. Unnecessary and annoying!

@digitalronin
Copy link

+1 This change would be really helpful.

@alterscape
Copy link

+1 This change would be extremely helpful here too.

@mvastola
Copy link
Contributor

+1 here too

@btatnall
Copy link

+1 as well.

@blindninja
Copy link

+1 I was hoping to try this out, but I can't because I have Rails 3.0.4

@kennethkalmer
Copy link
Collaborator

Fixed this guys, and pushed 2.0.0.rc7 to rubygems.org.

I know hard dependencies are an issue, but we need to tread lightly with this gem since we mimic some deep ActiveRecord magic in the code used to rebuild past revisions. The 3.0.4 ActiveRecord release had indeed changed some internals which caused AAA to break. I've updated and ensured the behavior is consistent for 3.0.3 & 3.0.4.

Unfortunately we can't make any guarantees for 3.0.5 releases at this point in time.

Cheers !

rocket-turtle pushed a commit to rocket-turtle/audited that referenced this issue Jan 4, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants