Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/pr/446'
Browse files Browse the repository at this point in the history
Conflicts:
	spec/performable_method_spec.rb
  • Loading branch information
albus522 committed Sep 24, 2014
2 parents 6c64064 + d9d2cbe commit 3b7cabc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/delayed/performable_method.rb
Expand Up @@ -19,7 +19,11 @@ def initialize(object, method_name, args)
end

def display_name
"#{object.class}##{method_name}"
if object.is_a?(Class)
"#{object}.#{method_name}"
else
"#{object.class}##{method_name}"
end
end

def perform
Expand Down
10 changes: 10 additions & 0 deletions spec/performable_method_spec.rb
Expand Up @@ -37,6 +37,16 @@ def private_method
expect { Delayed::PerformableMethod.new(clazz.new, :private_method, []) }.not_to raise_error
end

describe 'display_name' do
it 'returns class_name#method_name for instance methods' do
expect(Delayed::PerformableMethod.new('foo', :count, ['o']).display_name).to eq('String#count')
end

it 'returns class_name.method_name for class methods' do
expect(Delayed::PerformableMethod.new(Class, :inspect, []).display_name).to eq('Class.inspect')
end
end

describe 'hooks' do
%w[before after success].each do |hook|
it "delegates #{hook} hook to object" do
Expand Down

0 comments on commit 3b7cabc

Please sign in to comment.