Skip to content

Commit

Permalink
Allow user to override where DJ writes log output
Browse files Browse the repository at this point in the history
Fixes #712
  • Loading branch information
albus522 committed Oct 3, 2014
1 parent 5817625 commit a4c3d65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ Delayed::Worker.read_ahead = 10
Delayed::Worker.default_queue_name = 'default'
Delayed::Worker.delay_jobs = !Rails.env.test?
Delayed::Worker.raise_signal_exceptions = :term
Delayed::Worker.logger = Logger.new(File.join(Rails.root, 'log', 'delayed_job.log'))
```

Cleaning up
Expand Down
2 changes: 1 addition & 1 deletion lib/delayed/railtie.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class Railtie < Rails::Railtie
ActionMailer::Base.extend(Delayed::DelayMail)
end

Delayed::Worker.logger = if defined?(Rails)
Delayed::Worker.logger ||= if defined?(Rails)
Rails.logger
elsif defined?(RAILS_DEFAULT_LOGGER)
RAILS_DEFAULT_LOGGER
Expand Down

1 comment on commit a4c3d65

@bv-vijay
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delayed::Worker.logger ||= Logger.new(File.join(Rails.root, 'log', 'delayed_job.log'))... when this line comes logger is defined either Rails.logger or user specified logger. So when the user didn't specify any logger, delayed job not creating the default logger, instead it uses Rails.logger which could be the production log, finally the delayed job logs are mixed with production log.

Please sign in to comment.