New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log subscribers and support for JSON logs #1098
base: master
Are you sure you want to change the base?
Conversation
@albus522 can you review this please ? |
Would like to see JSON formatted logs! |
@albus522 do you think that this feature is not relevant for delayed jobs ? should I close the PR ? |
OMG this would be heaven! |
Would love to see this integrated. It is exactly what we need to feed Datadog with DJ logs that can be parsed w/o any extra configuration. In case JSON logging is considered too specific to integrate into DJ: having just the ActiveSupport::Notifications setup that this PR is built around would already be very useful. So people can easily attach their own JSON log subscriber, or whatever other type of subscriber. (Thanks @wshihadeh.) |
Would also love to see this merged. Would help with unifying log conventions with other Kubernetes logging configurations in our clusters. |
@wshihadeh - do you mind pulling master into this branch so people can direct-link this fork and use in Rails 6? |
9dbbf77
to
1330c0d
Compare
1330c0d
to
4e62dd2
Compare
@booleanbetrayal done , although it seems that this project is not active anymore. cc: @albus522 is that the case ? |
@albus522 do you have any objections for this one ? should I close it ? |
Extend delayed jobs logging to be able to support json format using log subscribers.
Example of the output