Fix for daemon options with arguments #1114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Daemon options take their own arguments. These weren't gettng passed in to the deamons gem properly. With this, is we... delayed_job stop --daemon-options '-w 42' the -w 42 gets passed through as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Daemon options take their own arguments. These weren't gettng
passed in to the deamons gem properly. With this, if we...
delayed_job stop --daemon-options '-w 42'
...the
-w 42gets passed through as expected.I'm wide open to suggestions for a cleaner/less hacky way to do this, but under a time crunch here to make this work quick, so this is what I've got at the moment.
I didn't see where
--daemon-optionswas currently being tested withindelayed_jobsso didn't update the tests.